Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused dependency #9101

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Aug 18, 2023

What included in this PR
Remove Docfx.Build.ConceptualDocuments project reference from Docfx.HtmlToPdf.csproj.

Background
Currently Docfx.HtmlToPdf.dll is loaded as plugin DLL at following lines.
Because it transitively referencing Docfx.Plugins project.

if (!IsDocfxPluginAssembly(assemblyFile))
{
Logger.LogVerbose($"Skipping non-plugin assembly: {assemblyName}.");
continue;
}
Assembly assembly;
try
{
assembly = Assembly.LoadFrom(assemblyFile);

It seems Docfx.Build.ConceptualDocuments is not used inside projects.
So It can safely removed.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f698eac) 77.57% compared to head (73eeaf7) 77.57%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9101      +/-   ##
==========================================
- Coverage   77.57%   77.57%   -0.01%     
==========================================
  Files         592      592              
  Lines       24608    24608              
==========================================
- Hits        19090    19089       -1     
- Misses       5518     5519       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit eb2bbdb into dotnet:main Aug 19, 2023
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Aug 21, 2023
@filzrev filzrev deleted the chore-remove-unused-dependency branch August 24, 2023 02:46
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants