perf: Optimize JToken to Dictionary conversion performance #9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9096 +/- ##
==========================================
- Coverage 77.57% 77.57% -0.01%
==========================================
Files 592 592
Lines 24608 24616 +8
==========================================
+ Hits 19090 19096 +6
- Misses 5518 5520 +2
☔ View full report in Codecov by Sentry. |
yufeih
approved these changes
Aug 18, 2023
| case JTokenType.Object: | ||
| return ConvertJObjectToDictionary((JObject)jToken); | ||
| default: | ||
| if (jToken is JValue jValue) |
There was a problem hiding this comment.
nit: why not also cast here?
Suggested change
| if (jToken is JValue jValue) | |
| return ((JValue)jToken).Value; |
There was a problem hiding this comment.
nit: why not also cast here?
There is some types that derived fromJTokenbut not JValue. (e.g. JContainer, JProperty)
(Thought these types should not be passed to this function)
yufeih
added
the
new-feature
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
* perf: optimize jToken conversion performance * fix: fix problems that may cause infinite loop * fix: add unit tests for code coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included in this PR
ConvertToObjectHelper.ConvertJObjectToObjectmethod performance.AggressiveOptimizationattribute.Background
When running Visual Studio profiler.
Sometimes
ConvertJObjectToObjectmethod is reported as Hot Path.And this method is called about
64702times when running docfx tosamples/seedprojecft.It seems
jObject.ToObject<Dictionary<string, object>>()call can be safely removed.Because
JObjectalready implementedIDictionary<string,JToken>interface implicitly.Rewrite code from
To