Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to sort enum member in declaring order #9093

Merged
merged 2 commits into from
Aug 21, 2023
Merged

feat: option to sort enum member in declaring order #9093

merged 2 commits into from
Aug 21, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Aug 17, 2023

Introduces an enumSortOrder option to specify enum member sort options:

  • alphabetic (default): Sort enum members in alphabetic order.
  • declaringOrder: Sort enum members in the order as they are declared in the source code.

fixes #2285

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: -0.01% ⚠️

Comparison is base (f698eac) 77.57% compared to head (a24c1d3) 77.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9093      +/-   ##
==========================================
- Coverage   77.57%   77.57%   -0.01%     
==========================================
  Files         592      592              
  Lines       24608    24614       +6     
==========================================
+ Hits        19090    19094       +4     
- Misses       5518     5520       +2     
Files Changed Coverage Δ
src/Docfx.Dotnet/YamlViewModelExtensions.cs 85.90% <87.50%> (-0.26%) ⬇️
src/Docfx.Dotnet/DotnetApiCatalog.cs 67.79% <100.00%> (+0.55%) ⬆️
...fx.Dotnet/ExtractMetadata/ExtractMetadataConfig.cs 100.00% <100.00%> (ø)
...fx.Dotnet/ExtractMetadata/ExtractMetadataWorker.cs 80.71% <100.00%> (ø)
src/Docfx.Dotnet/MetadataJsonConfig.cs 95.00% <100.00%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Aug 17, 2023
@yufeih yufeih reopened this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to not sort Enum values
2 participants