Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix code formatting #9025

Merged
merged 1 commit into from
Jul 29, 2023
Merged

chore: Fix code formatting #9025

merged 1 commit into from
Jul 29, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jul 28, 2023

What's included in this PR
In #9019, I've accidently overwrite csharp_space_between_method_declaration_parameter_list_parentheses rule to true.
and cause diff when running dotnet format command.

This PR fix this problem. and re-apply dotnet format command to entire solution.
(It fix namespace orders caused namespace changes from Microsoft.* to Docfx.*)

@filzrev filzrev changed the title chore: fix code formatting chore: Fix code formatting Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (c98926e) 76.87% compared to head (ac1dc07) 76.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9025      +/-   ##
==========================================
- Coverage   76.87%   76.87%   -0.01%     
==========================================
  Files         591      591              
  Lines       24758    24758              
==========================================
- Hits        19033    19032       -1     
- Misses       5725     5726       +1     
Files Changed Coverage Δ
src/Docfx.App/RunServe.cs 0.00% <ø> (ø)
src/Docfx.Build.Common/YamlHtmlPart.cs 100.00% <ø> (ø)
src/Docfx.Build.ConceptualDocuments/CountWord.cs 96.55% <ø> (ø)
src/Docfx.Build.Engine/DocumentBuildParameters.cs 100.00% <ø> (ø)
src/Docfx.Build.Engine/MarkupResultUtility.cs 95.78% <ø> (ø)
....Build.Engine/PostProcessors/ExtractSearchIndex.cs 87.34% <ø> (ø)
...Build.Engine/PostProcessors/HtmlDocumentHandler.cs 100.00% <ø> (ø)
...x.Build.Engine/PostProcessors/HtmlPostProcessor.cs 85.71% <ø> (ø)
...cfx.Build.Engine/PostProcessors/RemoveDebugInfo.cs 100.00% <ø> (ø)
...fx.Build.Engine/PostProcessors/ValidateBookmark.cs 100.00% <ø> (ø)
... and 40 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yufeih yufeih merged commit bbe9c67 into dotnet:main Jul 29, 2023
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jul 29, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants