refactor: Rewrite parameter null checks using helper methods #9024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9024 +/- ##
==========================================
+ Coverage 76.87% 77.55% +0.68%
==========================================
Files 591 591
Lines 24758 24578 -180
==========================================
+ Hits 19033 19062 +29
+ Misses 5725 5516 -209
☔ View full report in Codecov by Sentry. |
yufeih
approved these changes
Jul 29, 2023
src/Docfx.Build.Common/ModelAttributeHandlers/Handlers/MarkdownContentHandler.cs
Show resolved
Hide resolved
filzrev
added a commit
to filzrev/docfx
that referenced
this pull request
Jul 29, 2023
filzrev
added a commit
to filzrev/docfx
that referenced
this pull request
Jul 29, 2023
filzrev
added a commit
to filzrev/docfx
that referenced
this pull request
Jul 29, 2023
filzrev
added a commit
to filzrev/docfx
that referenced
this pull request
Jul 29, 2023
yufeih
pushed a commit
that referenced
this pull request
Aug 1, 2023
* fix: Add empty filePath check (based on previous doc comment) #9024 (comment) * chore: Fix additional CA1510 rules * chore: fix redundant names (IDE0020) Commented on #9024 (comment) * fix: Fix wrong behavior changes introduced by previous PR Commented on #9024 (comment) * fix: Change thrown exception type. Commented on #9024 (comment)
yufeih
added
the
engineering
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
…9024) refactor: rewrite guard statements to newer syntax
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
* fix: Add empty filePath check (based on previous doc comment) dotnet#9024 (comment) * chore: Fix additional CA1510 rules * chore: fix redundant names (IDE0020) Commented on dotnet#9024 (comment) * fix: Fix wrong behavior changes introduced by previous PR Commented on dotnet#9024 (comment) * fix: Change thrown exception type. Commented on dotnet#9024 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included in this PR
Rewrite parameter null check with following helper methods.
ArgumentNullException.ThrowIfNull(Require .NET 6 or later)ArgumentNullException.ThrowIfNullOrEmpty(Require .NET 7)These change will not affects application behaviors.
It's intended following purpose.
Related Roslyn Analyzer rules
CA1510: Use ArgumentNullException throw helper
https://github.com/dotnet/roslyn-analyzers/blob/main/src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.md#ca1510-use-argumentnullexception-throw-helper