-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package path to reduce nupkg size #8876
Conversation
CI Tests failed with following error.
It seems recent PR tests failed with same issues. |
@@ -13,7 +13,7 @@ | |||
</Target> | |||
|
|||
<ItemGroup> | |||
<Content Include="templates/**" CopyToOutputDirectory="PreserveNewest" PackageCopyToOutput="true" /> | |||
<Content Include="templates/**" CopyToOutputDirectory="PreserveNewest" PackageCopyToOutput="true" PackagePath="contentFiles/any/any/templates"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change breaks the docfx
package shipped as a global tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR change don't affects docfx.nupkg
contents.
(Because docfx
reference Microsoft.DocAsCode.App
as ProjectReference
)
So there is no breaking changes.
I though there are 3 execution type to run docfx toolset.
- Run
docfx
as .NET global tool (and .NET local tool) - Run
docfx
Self-Contained exe that is published on GitHub Release Page - Run custom application that use
Microsoft.DocAsCode.App
package.
1.
and 2.
behaviors are guaranteed by there is no output content changes.
And 3.
is tested on my local environment. and confirmed no behavior changes.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8876 +/- ##
==========================================
- Coverage 77.00% 76.99% -0.02%
==========================================
Files 605 605
Lines 25036 25036
==========================================
- Hits 19280 19277 -3
- Misses 5756 5759 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @filzrev, this is a great approach!
I've confirmed Microsoft.DocAsCode.App 2.67.5 NuGet package size is reduced from |
Currently build-in templates don't contains target framework dependent plugin DLLs.
But
Microsoft.DocAsCode.App.nupkg
contains duplicated content files as below.This PR set
PackagePath
as Language- and framework-agnosticand
templates
resources are packed to following shared path.This PR reduce
Microsoft.DocAsCode.App.nupkg
package size.docfx.nupkg
package size issue described at #8691 needs additional works.