fix: Enable InvalidFileLink check when custom hrefGenerator is used #8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8845 +/- ##
==========================================
- Coverage 77.00% 77.00% -0.01%
==========================================
Files 605 605
Lines 25033 25036 +3
==========================================
+ Hits 19277 19279 +2
- Misses 5756 5757 +1
☔ View full report in Codecov by Sentry. |
filzrev
deleted the
enable-filelink-warning-when-customhrefgenerator-used
branch
yufeih
added
the
bug-fix
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
…otnet#8845) fix: enable InvalidFileLink warnings. if custom href generator returns original href
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve following problem.
When custom
hrefGeneratoris used.InvalidFileLink warning check is always skipped.
This PR add additional check that
hrefGeneratorreturnsnew hrefor not.If
hrefis not modified. then execute normal InvalidFileLink check path.