Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: globalMetadataFiles and fileMetadataFiles not working #8828

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jun 5, 2023

Fixes #8822 #8815

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Jun 5, 2023
@yufeih yufeih force-pushed the globalmetadatafile branch from 64ee0da to 8703a51 Compare June 5, 2023 03:02
@yufeih yufeih force-pushed the globalmetadatafile branch from 8703a51 to fc53e94 Compare June 5, 2023 03:03
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18 🎉

Comparison is base (f28165a) 76.81% compared to head (c41c81a) 77.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8828      +/-   ##
==========================================
+ Coverage   76.81%   77.00%   +0.18%     
==========================================
  Files         606      605       -1     
  Lines       25050    25033      -17     
==========================================
+ Hits        19243    19276      +33     
+ Misses       5807     5757      -50     
Impacted Files Coverage Δ
...ft.DocAsCode.App/Helpers/DocumentBuilderWrapper.cs 80.55% <100.00%> (+9.45%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih closed this Jun 5, 2023
@yufeih yufeih reopened this Jun 5, 2023
@yufeih yufeih closed this Jun 5, 2023
@yufeih yufeih reopened this Jun 5, 2023
@yufeih yufeih merged commit d5a3d28 into main Jun 5, 2023
@yufeih yufeih deleted the globalmetadatafile branch June 5, 2023 07:03
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] globalMetadataFiles not working
1 participant