Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support of template as zip files and embedded resources #8811

Merged
merged 1 commit into from
May 30, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 30, 2023

BREAKING CHANGE: Drop support of template as zip files and embedded resources in assemblies, making it easier to load plugins in templates without copying the plugin assemblies to a temp directory.

#8740

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: -0.10 ⚠️

Comparison is base (194e503) 76.94% compared to head (a8ae670) 76.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8811      +/-   ##
==========================================
- Coverage   76.94%   76.84%   -0.10%     
==========================================
  Files         607      606       -1     
  Lines       25058    25039      -19     
==========================================
- Hits        19280    19241      -39     
- Misses       5778     5798      +20     
Impacted Files Coverage Δ
src/docfx/Models/TemplateCommand.cs 0.00% <0.00%> (ø)
...Build.Engine/TemplateProcessors/TemplateManager.cs 86.27% <85.71%> (-2.37%) ⬇️
src/Microsoft.DocAsCode.App/RunBuild.cs 63.63% <100.00%> (-1.59%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit 2c2a2e0 into main May 30, 2023
@yufeih yufeih deleted the zip-template branch May 30, 2023 04:28
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant