Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: array options not bound to command line args #8784

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 18, 2023

fixes #8760

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (411bd6d) 76.95% compared to head (2cc65f9) 76.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8784      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.01%     
==========================================
  Files         606      607       +1     
  Lines       25054    25058       +4     
==========================================
+ Hits        19280    19281       +1     
- Misses       5774     5777       +3     
Impacted Files Coverage Δ
src/docfx/Extensions/ArrayOptionConverter.cs 0.00% <0.00%> (ø)
src/docfx/Models/BuildCommandOptions.cs 90.00% <ø> (ø)
src/docfx/Models/PdfCommandOptions.cs 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit f2f31fc into main May 18, 2023
@yufeih yufeih deleted the array-cmd-open branch May 18, 2023 02:07
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] At the build stage, it does not find custom template styles if you use command line
1 participant