Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward build command args to default command #8689

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Apr 26, 2023

fixes #8688

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 61.11% and project coverage change: +0.19 🎉

Comparison is base (30be6fe) 76.72% compared to head (42ce6fa) 76.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8689      +/-   ##
==========================================
+ Coverage   76.72%   76.91%   +0.19%     
==========================================
  Files         606      606              
  Lines       25062    25062              
==========================================
+ Hits        19229    19277      +48     
+ Misses       5833     5785      -48     
Impacted Files Coverage Δ
src/docfx/Models/BuildCommand.cs 37.73% <0.00%> (+37.73%) ⬆️
src/docfx/Models/PdfCommand.cs 0.00% <0.00%> (ø)
src/docfx/Models/ServeCommand.cs 0.00% <ø> (ø)
src/docfx/Models/DefaultCommand.cs 90.90% <91.66%> (+13.13%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit 95d113d into main Apr 26, 2023
@yufeih yufeih deleted the foward-build-command-args branch April 26, 2023 12:07
@Meandron
Copy link

@yufeih: Thank you very much for the quick fix and the new release! I highly appreciate!

@yufeih
Copy link
Contributor Author

yufeih commented Apr 26, 2023

@yufeih: Thank you very much for the quick fix and the new release! I highly appreciate!

No Problem. Thank you for reporting the issue!

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error on unknown command line options (build and help)
2 participants