Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined lunrIndex #8556

Merged
merged 1 commit into from
Mar 26, 2023
Merged

fix: undefined lunrIndex #8556

merged 1 commit into from
Mar 26, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 26, 2023

The modern templates disables the search box until search index is ready, add a guard nevertheless.

fixes #7883

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Mar 26, 2023
@yufeih yufeih merged commit 12a12a1 into main Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (7a93598) 75.30% compared to head (7ac1d47) 75.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8556      +/-   ##
==========================================
- Coverage   75.30%   75.28%   -0.02%     
==========================================
  Files         650      650              
  Lines       23972    23972              
==========================================
- Hits        18051    18048       -3     
- Misses       5921     5924       +3     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search service worker error
1 participant