feat: compute mslearn symbol URL #8546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufeih
added
the
new-feature
yufeih
force-pushed
the
symbolurl-mslearn
branch
from
2cee4e3
to
ad78f63
Compare
|
Is there a way or API to link to articles (conceptual topics) in the Microsoft Learn Docs? |
yufeih
force-pushed
the
symbolurl-mslearn
branch
from
ad78f63
to
2c0a4bc
Compare
No at the moment. URL is the way for external site to link to MSLearn docs, most high traffic pages would setup redirection on URL change. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8546 +/- ##
==========================================
+ Coverage 75.15% 75.21% +0.06%
==========================================
Files 643 645 +2
Lines 23558 23637 +79
==========================================
+ Hits 17704 17779 +75
- Misses 5854 5858 +4
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xref service was introduced to provide fast query by
uidwith a database backend. Microsoft Learn today still maintains and hosts an xref service for the .NET BCL, it is only used by the open-source community today and may be retired in the future.There are also limitations of using xrefmap as intermediary in resolving .NET API cross references, e.g., missing info in xrefmaps causes
<inheritdoc />problems. We’d like to move to a future where API references are resolved directly based onSymbols, both the content and URLs.URLs can be resolved based on conventions. This first step decouples docfx from mslearn xref service by matching assembly names against a list of assemblies published to mslearn and resolving them based on mslearn URL convention.
#8567 #5053 #3597