Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update docfx to use modern template #8513

Merged
merged 2 commits into from
Mar 14, 2023
Merged

feat: update docfx to use modern template #8513

merged 2 commits into from
Mar 14, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 14, 2023

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Mar 14, 2023
@yufeih yufeih force-pushed the docfx-modern branch 3 times, most recently from 2a090ad to 819ccd6 Compare March 14, 2023 09:19
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.08 🎉

Comparison is base (4a1e32d) 76.18% compared to head (f615e00) 76.26%.

❗ Current head f615e00 differs from pull request most recent head 7c9a771. Consider uploading reports for the commit 7c9a771 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8513      +/-   ##
==========================================
+ Coverage   76.18%   76.26%   +0.08%     
==========================================
  Files         858      858              
  Lines       30644    30647       +3     
==========================================
+ Hits        23345    23373      +28     
+ Misses       7299     7274      -25     
Impacted Files Coverage Δ
src/Microsoft.DocAsCode.App/RunServe.cs 0.00% <0.00%> (ø)
src/Microsoft.DocAsCode.App/Docset.cs 100.00% <100.00%> (+100.00%) ⬆️
...ild.Engine/TemplateProcessors/TemplateProcessor.cs 88.00% <100.00%> (+0.50%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih force-pushed the docfx-modern branch 2 times, most recently from e6c1834 to 59a77f8 Compare March 14, 2023 11:27
@yufeih yufeih marked this pull request as ready for review March 14, 2023 11:27
@yufeih yufeih closed this Mar 14, 2023
@yufeih yufeih reopened this Mar 14, 2023
@yufeih yufeih merged commit 52c0f3c into main Mar 14, 2023
@yufeih yufeih deleted the docfx-modern branch March 14, 2023 12:48
@sotanakamura
Copy link
Contributor

Very nice theme, looks like microsoft docs. Thanks for your hard work @yufeih

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants