Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Newtonsoft.Json.Schema -> JsonSchema.Net #8418

Merged
merged 5 commits into from
Feb 18, 2023
Merged

fix: Newtonsoft.Json.Schema -> JsonSchema.Net #8418

merged 5 commits into from
Feb 18, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Feb 17, 2023

#4250

BREAKING CHANGE: JSON Schema $ref can only reference subschemas defined in the #/definitions/ section.

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Feb 17, 2023
@yufeih yufeih marked this pull request as ready for review February 17, 2023 13:08
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 77.10% // Head: 77.17% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (cd2e4c9) compared to base (8252e5b).
Patch coverage: 96.49% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8418      +/-   ##
==========================================
+ Coverage   77.10%   77.17%   +0.07%     
==========================================
  Files         860      859       -1     
  Lines       30773    30696      -77     
==========================================
- Hits        23726    23690      -36     
+ Misses       7047     7006      -41     
Impacted Files Coverage Δ
.../Microsoft.DocAsCode.App/Config/BuildJsonConfig.cs 88.37% <ø> (-0.27%) ⬇️
...ft.DocAsCode.App/Helpers/DocumentBuilderWrapper.cs 79.03% <ø> (-0.12%) ⬇️
....DocAsCode.Build.Engine/DocumentBuildParameters.cs 100.00% <ø> (ø)
src/docfx/Models/BuildCommandOptions.cs 97.14% <ø> (-0.08%) ⬇️
src/docfx/SubCommands/BuildCommand.cs 66.66% <ø> (-0.18%) ⬇️
...AsCode.Build.SchemaDriven/Models/DocumentSchema.cs 83.75% <93.93%> (+11.10%) ⬆️
...icrosoft.DocAsCode.Build.Engine/DocumentBuilder.cs 74.87% <100.00%> (-0.63%) ⬇️
....DocAsCode.Build.SchemaDriven/Models/BaseSchema.cs 100.00% <100.00%> (ø)
...Code.Build.SchemaDriven/SchemaFragmentsIterator.cs 81.39% <100.00%> (ø)
...e.Build.SchemaDriven/Validators/SchemaValidator.cs 100.00% <100.00%> (+15.00%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant