Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bootstrap variable override problem #10412

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 21, 2024

This PR intend to fix issue #10411

What's changed

  1. Remove SCSS variable override. Instead, directly pass SCSS variable override by with Configuration syntax.
  2. Remove $enable-important-utilities: false; setting.

Background

PR #10301 changes @import statement to @use statement to suppress following warnings.

[WARNING] Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

These changes are automatically refactored by using sass-migrator command.
But after these changes. It seems SCSS variable override is not works as expected.
And regression seems not detected by percy visual regression tests.
Because percy tests with following display resolution widths (375px/1280px)

@yufeih yufeih merged commit 7102b42 into dotnet:main Nov 21, 2024
7 checks passed
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants