fix: ignore unsupported PDB formats (#8631)

dotnet · Apr 12, 2023 · 9888f99 · 9888f99
1 parent a9fb70e
commit 9888f99
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/Microsoft.DocAsCode.Dotnet/SymbolUrlResolver.SourceLink.cs b/src/Microsoft.DocAsCode.Dotnet/SymbolUrlResolver.SourceLink.cs
@@ -40,9 +40,16 @@ partial class SymbolUrlResolver
                 return null;
             }
 
-            return new(
-                new PEReader(File.OpenRead(pe.FilePath)),
-                MetadataReaderProvider.FromPortablePdbStream(File.OpenRead(pdbPath)));
+            try
+            {
+                return new(
+                    new PEReader(File.OpenRead(pe.FilePath)),
+                    MetadataReaderProvider.FromPortablePdbStream(File.OpenRead(pdbPath)));
+            }
+            catch (BadImageFormatException)
+            {
+                return null;
+            }
         }
     }
 

diff --git a/src/Microsoft.DocAsCode.Dotnet/Visitors/SymbolVisitorAdapter.cs b/src/Microsoft.DocAsCode.Dotnet/Visitors/SymbolVisitorAdapter.cs
@@ -431,14 +431,7 @@ public string AddSpecReference(
         IReadOnlyList<string> typeGenericParameters = null,
         IReadOnlyList<string> methodGenericParameters = null)
     {
-        try
-        {
-            return _generator.AddSpecReference(symbol, typeGenericParameters, methodGenericParameters, _references, this);
-        }
-        catch (Exception ex)
-        {
-            throw new DocfxException($"Unable to generate spec reference for {VisitorHelper.GetCommentId(symbol)}", ex);
-        }
+        return _generator.AddSpecReference(symbol, typeGenericParameters, methodGenericParameters, _references, this);
     }
 
     private MemberType GetMemberTypeFromSymbol(ISymbol symbol)