Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate diagnostics repo to 1ES #4567

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Migrate diagnostics repo to 1ES #4567

merged 6 commits into from
Mar 29, 2024

Conversation

mikem8361
Copy link
Member

No description provided.

@mikem8361 mikem8361 requested a review from hoyosjs March 27, 2024 01:18
@mikem8361 mikem8361 self-assigned this Mar 27, 2024
@mikem8361 mikem8361 force-pushed the mikem/1es-migration branch from 9f636ad to c33f7d6 Compare March 28, 2024 23:34
@mikem8361 mikem8361 requested review from mmitche and mdh1418 and removed request for mmitche March 28, 2024 23:40
@mikem8361
Copy link
Member Author

@mdh1418, this 1ES PR is ready for review.

/cc: @tommcdon

mdh1418
mdh1418 reviewed Mar 29, 2024
View reviewed changes
eng/pipelines/build.yml Outdated Show resolved Hide resolved
diagnostics.yml Outdated Show resolved Hide resolved
diagnostics.yml Show resolved Hide resolved
diagnostics.yml Outdated Show resolved Hide resolved
diagnostics.yml Show resolved Hide resolved
eng/pipelines/template1es.yml Show resolved Hide resolved
eng/pipelines/templatePublic.yml Show resolved Hide resolved
eng/pipelines/template1es.yml Show resolved Hide resolved
eng/pipelines/prepare-release.yml Outdated Show resolved Hide resolved
eng/pipelines/build.yml Show resolved Hide resolved
@mdh1418
Copy link
Member

mdh1418 commented Mar 29, 2024

Seems like we hit the TestLogsUseAppFiltersAndFilterSpecs failure from #2541 in the internal Alpine x64 Release build. Sounds like its a flakey failure? Retrying the failed lane so we can see the post build steps

@mdh1418
Copy link
Member

mdh1418 commented Mar 29, 2024

It looks like retries now fail when trying to upload artifacts via the 1es.PublishPipelineArtifact@1 task if it succeeded in a previously attempt.

Triggering a whole new build for a flakey test failure is pretty inefficient. I wonder if we should upload logs per attempt? Maybe if the task notices that there is a duplicate, it can add a second attempt?

mdh1418
mdh1418 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as the current internal build's post build steps are successful! Thanks!

@mikem8361 mikem8361 merged commit a41c740 into dotnet:main Mar 29, 2024
18 checks passed
@mikem8361 mikem8361 deleted the mikem/1es-migration branch March 29, 2024 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdh1418 mdh1418 mdh1418 approved these changes

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

@mikem8361 mikem8361

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikem8361 @mdh1418 @hoyosjs