[Dotnet Monitor] Add Metadata Support For CounterPayload
#3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
reviewed
Nov 8, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Nov 8, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/CounterPayload.cs
Show resolved
Hide resolved
jander-msft
reviewed
Nov 8, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Nov 10, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/ICounterPayload.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Nov 10, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/ICounterPayload.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Nov 10, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Nov 22, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/CounterPayload.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Nov 22, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Show resolved
Hide resolved
wiktork
reviewed
Nov 22, 2022
src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
Outdated
Show resolved
Hide resolved
wiktork
approved these changes
Nov 22, 2022
|
@dotnet/dotnet-diag would anyone be able to review/sign off on this? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are the first part of addressing dotnet/dotnet-monitor#430; the second part will be integrated directly into the
dotnet-monitorrepo.