Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help for command flag of dotnet-dump #3151

Merged
6 commits merged into from
Jun 29, 2022
Merged

Add help for command flag of dotnet-dump #3151

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68cbe61
Add help for command flag of dotnet-dump
hoyosjs Jun 28, 2022
b4fcc4c
Update Program.cs
hoyosjs Jun 28, 2022
ef60af0
Update Program.cs
hoyosjs Jun 28, 2022
b757318
Update Program.cs
hoyosjs Jun 28, 2022
2cd2b89
Update Program.cs
hoyosjs Jun 28, 2022
fc5fd78
Update src/Tools/dotnet-dump/Program.cs
hoyosjs Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tools/dotnet-dump/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ private static Argument DumpPath() =>
private static Option RunCommand() =>
new Option(
aliases: new[] { "-c", "--command" },
description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want to exit analysis after the commands, you must explicitly add an 'exit' command at the end.")
description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want to dotnet dump to exit after the commands, your last command should be 'exit'.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "If you want dotnet dump to exit..." , removing the "to" before "dotnet".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nuts! I do'nt have write access to this repo so I can't fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want to dotnet dump to exit after the commands, your last command should be 'exit'.")
description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want dotnet dump to exit after the commands, your last command should be 'exit'.")

{
Argument = new Argument<string[]>(name: "command", getDefaultValue: () => Array.Empty<string>()) { Arity = ArgumentArity.ZeroOrMore }
};
Expand Down