Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 'symbolicate' commands to dotnet-stack #2436

Merged
merged 9 commits into from
Aug 25, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Tools/dotnet-stack/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public static Task<int> Main(string[] args)
var parser = new CommandLineBuilder()
.AddCommand(ReportCommandHandler.ReportCommand())
.AddCommand(ProcessStatusCommandHandler.ProcessStatusCommand("Lists the dotnet processes that traces can be collected"))
.AddCommand(SymbolicateHandler.SymbolicateCommand())
.UseDefaults()
.Build();

Expand Down
388 changes: 388 additions & 0 deletions src/Tools/dotnet-stack/Symbolicate.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,388 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using Microsoft.DiaSymReader.Tools;
using Microsoft.Tools.Common;
using System;
using System.Collections.Generic;
using System.CommandLine;
using System.CommandLine.Binding;
using System.CommandLine.IO;
using System.IO;
using System.Text;
using System.Text.RegularExpressions;
using System.Xml;

namespace Microsoft.Diagnostics.Tools.Stack
{
internal static class SymbolicateHandler
{
// Temporary folder to store the files converted from pdb to xml
private static readonly string tempDirectory = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
private static readonly Regex regex = new Regex(@" at (?<type>[\w+\.?]+)\.(?<method>\w+)\((?<params>.*)\) in (?<filename>[\w+\.?]+)(\.dll|\.ni\.dll): token (?<token>0x\d+)\+(?<offset>0x\d+)", RegexOptions.Compiled);

delegate void SymbolicateDelegate(IConsole console, FileInfo inputPath, DirectoryInfo[] searchDir, string output);

/// <summary>
/// Get the line number from the Method Token and IL Offset at the stacktrace
/// </summary>
/// <param name="console"></param>
/// <param name="inputPath">The input path for file with stacktrace text</param>
/// <param name="searchDir">All paths in the directory to the assembly and pdb where the exception occurred</param>
/// <param name="output">The output path for the extracted line number data</param>
/// <returns></returns>
private static void Symbolicate(IConsole console, FileInfo inputPath, DirectoryInfo[] searchDir, string output)
{
try
{
List<string> search_paths = new List<string>();
if (searchDir.Length == 0)
{
search_paths.Add(Directory.GetCurrentDirectory());
}
else
{
foreach (var path in searchDir)
{
search_paths.Add(path.FullName);
}
}

Symbolicator(console, PdbToXmlConvert(search_paths), inputPath.FullName, output);
}
catch (Exception e)
{
Console.Error.WriteLine(e.Message);
JongHeonChoi marked this conversation as resolved.
Show resolved Hide resolved
}
}

private static List<string> PdbToXmlConvert(List<string> searchPaths)
{
List<string> peFiles = GrabFiles(searchPaths, "*.dll");
if (peFiles.Count == 0)
{
throw new FileNotFoundException("Assembly file not found\n");
}
peFiles.Sort();

List<string> pdbFiles = GrabFiles(searchPaths, "*.pdb");
if (pdbFiles.Count == 0)
{
throw new FileNotFoundException("PDB file not found\n");
}
pdbFiles.Sort();

Directory.CreateDirectory(tempDirectory);

List<string> xmlList = new List<string>();
int pdbCnt = 0;
for (int peCnt = 0; peCnt < peFiles.Count; peCnt++)
{
int compare = string.Compare(Path.GetFileNameWithoutExtension(peFiles[peCnt]), Path.GetFileNameWithoutExtension(pdbFiles[pdbCnt]), StringComparison.OrdinalIgnoreCase);
if (compare == 0)
{
string xmlPath = Path.Combine(tempDirectory, Path.GetFileName(Path.ChangeExtension(peFiles[peCnt], "xml")));
GenXmlFromPdb(peFiles[peCnt], pdbFiles[pdbCnt++], xmlPath);
xmlList.Add(xmlPath);
}
else if (compare > 0) {
pdbCnt++;
peCnt--;
}
if (pdbCnt == pdbFiles.Count) break;
}
return xmlList;
}

private static List<string> GrabFiles(List<string> paths, string searchPattern)
{
List<string> files = new List<string>();
foreach (var assemDir in paths)
{
if (Directory.Exists(assemDir))
{
foreach (var peFile in Directory.GetFiles(assemDir, searchPattern, SearchOption.AllDirectories))
{
files.Add(peFile);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
foreach (var peFile in Directory.GetFiles(assemDir, searchPattern, SearchOption.AllDirectories))
{
files.Add(peFile);
}
files.AddRange(Directory.GetFiles(assemDir, searchPattern, SearchOption.AllDirectories));

}
}
return files;
}

private static void GenXmlFromPdb(string assemblyPath, string pdbPath, string xmlPath)
{
using var peStream = new FileStream(assemblyPath, FileMode.Open, FileAccess.Read);
using var pdbStream = new FileStream(pdbPath, FileMode.Open, FileAccess.Read);
using var dstFileStream = new FileStream(xmlPath, FileMode.Create, FileAccess.ReadWrite);
using var sw = new StreamWriter(dstFileStream, Encoding.UTF8);
PdbToXmlOptions options = PdbToXmlOptions.ResolveTokens | PdbToXmlOptions.IncludeTokens;

PdbToXmlConverter.ToXml(sw, pdbStream, peStream, options);
}

private static void RemoveTempDirectory()
{
if (Directory.Exists(tempDirectory))
{
Directory.Delete(tempDirectory, true);
}
}

private static void Symbolicator(IConsole console, List<string> xmlList, string inputPath, string outputPath)
{
if (xmlList.Count == 0)
{
RemoveTempDirectory();
throw new FileNotFoundException("Xml file not found\n");
}

GetLineFromStack(console, xmlList, inputPath, outputPath);

RemoveTempDirectory();
}

internal sealed class StackTraceInfo
{
public string Type;
public string Method;
public string Param;
public string Assembly;
public string Token;
public string Offset;
public string Document;
public string Filepath;
public string Filename;
public string StartLine;
public string EndLine;
}

private static void GetLineFromStack(IConsole console, List<string> xmlList, string inputPath, string outputPath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the name of this function reflects what it is doing. Perhaps something like SymbolicateFile?

Get implies this returns something, but it returns void.

{
try
{
string output = string.Empty;

StreamWriter fsw = null;
if (outputPath != null)
{
fsw = new StreamWriter(new FileStream(outputPath, FileMode.Create, FileAccess.Write));
output = $"\nOutput: {outputPath}\n";
}

using StreamReader fsr = new StreamReader(new FileStream(inputPath, FileMode.Open, FileAccess.Read));
while (!fsr.EndOfStream)
{
string line = fsr.ReadLine();
if (!line.Contains("at ") || !line.Contains("+"))
{
fsw?.WriteLine(line);
console.Out.WriteLine($"{line}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in a previous comment chain, we had decided to only print to a file. We can have it print to the console, but we should put it behind a --stdout flag or something similar.

continue;
}
string ret = GetRegex(line, xmlList);
fsw?.WriteLine(ret);
console.Out.WriteLine($"{ret}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting for a single string is unnecessary work. This can just be Console.Out.WriteLine(ret).

}
fsw?.Close();
console.Out.WriteLine($"{output}");
}
catch (Exception e)
{
Console.Error.WriteLine(e);
JongHeonChoi marked this conversation as resolved.
Show resolved Hide resolved
}
}

private static string GetRegex(string line, List<string> xmlList)
{
string ret = line;
Match match = regex.Match(ret);
if (!match.Success)
{
return ret;
}

StackTraceInfo stInfo = new StackTraceInfo() {
Type = match.Groups["type"].Value,
Method = match.Groups["method"].Value,
Param = match.Groups["params"].Value,
Assembly = match.Groups["filename"].Value,
Token = match.Groups["token"].Value,
Offset = match.Groups["offset"].Value
};

string xmlStr = stInfo.Assembly.Contains(".ni.dll") ? stInfo.Assembly.Replace(".ni.dll", ".xml") : stInfo.Assembly.Replace(".dll", ".xml");
foreach (var xmlPath in xmlList)
{
if (xmlPath.Contains(xmlStr))
{
GetLineFromXml(xmlPath, stInfo);
if (stInfo.Filepath != null && stInfo.StartLine != null)
{
ret = $" at {stInfo.Type}.{stInfo.Method}({stInfo.Param}) in {stInfo.Filepath}:line {stInfo.StartLine}";
break;
}
}
}
return ret;
}

private static void GetLineFromXml(string xmlPath, StackTraceInfo stInfo)
{
try
{
XmlDocument xmlDoc = new XmlDocument();
xmlDoc.Load(xmlPath);
XmlElement xRoot = xmlDoc.DocumentElement;
XmlNodeList xnList = xRoot.ChildNodes;
int xnCount = xnList.Count;
if (xnCount > 0)
{
for (int i = xnCount - 1; i >= 0; i--)
{
XmlNode node = xnList[i];
if (node.Name == "files")
{
ParseFile(node.ChildNodes, stInfo);
}
else if (node.Name == "methods")
{
ParseMethod(node.ChildNodes, stInfo);
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we cache this load and the symbol lookup? This looks like it's going to load the file, parse the XML, and walk every method in the parsed XML for every frame of a stack trace. If a stack has many frames from a single assembly with a large PDB, this could be expensive.

}
catch (ArgumentException e)
{
Console.Error.WriteLine(e);
}
}

private static void ParseFile(XmlNodeList xn, StackTraceInfo stInfo)
{
try
{
foreach (XmlNode node in xn)
{
if (stInfo.Document == node.Attributes["id"].Value)
{
stInfo.Filepath = node.Attributes["name"].Value;
stInfo.Filename = Path.GetFileName(node.Attributes["name"].Value);
}
}
}
catch (ArgumentException e)
{
Console.Error.WriteLine(e);
JongHeonChoi marked this conversation as resolved.
Show resolved Hide resolved
}
}

private static void ParseMethod(XmlNodeList xn, StackTraceInfo stInfo)
{
try
{
foreach (XmlNode node in xn)
{
if (stInfo.Type == node.Attributes["containingType"].Value &&
stInfo.Method == node.Attributes["name"].Value &&
stInfo.Token == node.Attributes["token"].Value)
{
if (node.Attributes.Item(2).Name == "parameterNames")
{
stInfo.Param = node.Attributes["parameterNames"].Value;
}
ParseSequence(node.ChildNodes, stInfo);
}
}
}
catch (ArgumentException e)
{
Console.Error.WriteLine(e);
JongHeonChoi marked this conversation as resolved.
Show resolved Hide resolved
}
}

private static void ParseSequence(XmlNodeList xn, StackTraceInfo stInfo)
{
try
{
foreach (XmlNode node in xn)
{
if (node.Name == "sequencePoints")
{
ParseEntry(node.ChildNodes, stInfo);
}
}
}
catch (ArgumentException e)
{
Console.Error.WriteLine(e);
}
}

private static void ParseEntry(XmlNodeList xn, StackTraceInfo stInfo)
{
try
{
XmlNode bestPointSoFar = null;
long ilOffset = Convert.ToInt64(stInfo.Offset, 16);
foreach (XmlNode node in xn)
{
// If the attribute is not 'startLine', but 'hidden', select the best value so far
if (Convert.ToInt64(node.Attributes["offset"].Value, 16) > ilOffset)
{
break;
}
if (node.Attributes["startLine"] != null)
{
bestPointSoFar = node;
}
}
if (bestPointSoFar != null)
{
stInfo.StartLine = bestPointSoFar.Attributes["startLine"].Value;
stInfo.EndLine = bestPointSoFar.Attributes["endLine"].Value;
stInfo.Document = bestPointSoFar.Attributes["document"].Value;
}
}
catch (ArgumentException e)
{
Console.Error.WriteLine(e);
}
}

public static Command SymbolicateCommand() =>
new Command(
name: "symbolicate", description: "Get the line number from the Method Token and IL Offset in a stacktrace")
{
// Handler
HandlerDescriptor.FromDelegate((SymbolicateDelegate)Symbolicate).GetCommandHandler(),
// Arguments and Options
InputArgument(),
SearchDirectoryOption(),
OutputOption()
};

public static Argument<FileInfo> InputArgument() =>
new Argument<FileInfo>(name: "input-path")
{
Description = "Path to the stacktrace text file",
Arity = ArgumentArity.ExactlyOne
}.ExistingOnly();

public static Option<DirectoryInfo[]> SearchDirectoryOption() =>
new Option<DirectoryInfo[]>(new[] { "-d", "--search-dir" }, "Path of multiple directories with assembly and pdb")
{
Argument = new Argument<DirectoryInfo[]>(name: "directory1 directory2 ...", getDefaultValue: () => new DirectoryInfo(Directory.GetCurrentDirectory()).GetDirectories())
{
Arity = ArgumentArity.ZeroOrMore
}.ExistingOnly()
};

public static Option<string> OutputOption() =>
new Option<string>(new[] { "-o", "--output" }, "Output directly to a file")
{
Argument = new Argument<string>(name: "output-path")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, in the latest versions of System.CommandLine, this property is not accessible.

};
}
}
Loading