Add GetProcessInfo2 command, response, tests, and docs. #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktork
reviewed
Jun 11, 2021
src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
Outdated
Show resolved
Hide resolved
Fix IEndpointInfo.ClrProductVersionString property name.
jander-msft
commented
Jun 11, 2021
jander-msft
commented
Jun 25, 2021
…/jander/processinfo2
Fix other minor post-merge issues.
josalem
reviewed
Jun 30, 2021
There was a problem hiding this comment.
Changes look good to me. Would you rather go through with merging now and come back to fix up the code after dotnet/runtime#54083 is fixed, or hold off till it's fixed?
I think I'd like to get this in now and then come back later that just uncomments the few places that need it and add some retry logic where appropriate. |
josalem
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by dotnet/runtime#54083