Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCo…

…unterTriggerTests.EventCounterTriggerWithEventPipePipelineTest (#2569) * Disabling EventLogsPipeUnitTests.TestLogsWildcardCategory and EventCounterTriggerTests.EventCounterTriggerWithEventPipePipelineTest They are constantly failing. * Only skip on Windows * Disabled EventLogsPipelineUnitTests.TestLogsAllCategoriesAllLevels for Windows also * Disable an unreliable SOS test on MacOS (#1950)
dotnet · Sep 8, 2021 · 97201dd · 97201dd
1 parent efc8030
commit 97201dd
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/src/SOS/SOS.UnitTests/Scripts/GCTests.script b/src/SOS/SOS.UnitTests/Scripts/GCTests.script
@@ -158,6 +158,11 @@ VERIFY:Break instruction exception - code 80000003
 ENDIF:CDB
 
 SOSCOMMAND:EEHeap -gc
+
+# DumpStackObjects does not work here on 6.0 MacOS
+# https://github.com/dotnet/diagnostics/issues/1950
+!IFDEF:OSX
+
 SOSCOMMAND:DumpStackObjects
 SOSCOMMAND:GCWhere <POUT>\w+\s+(<HEXVAL>)\s+([Gg][Cc]where!\$0_)*GCWhere\s+<POUT>
 # we care that the Gen is 2
@@ -167,17 +172,20 @@ SOSCOMMAND:GCRoot <PREVPOUT>
 VERIFY:.*Thread <HEXVAL>:
 VERIFY:\s+<HEXVAL>\s+<HEXVAL>\s+GCWhere\.Main\(\)\s+\[.*[/|\\][Gg][Cc][Ww]here\.cs\s+@\s+45\]\s+
 
+ENDIF:OSX
+
 # Continue to the next DebugBreak
 CONTINUE
 IFDEF:CDB
 VERIFY:Break instruction exception - code 80000003
 ENDIF:CDB
 
+SOSCOMMAND:EEHeap -gc
+
 # DumpStackObjects does not work here on 6.0 MacOS
 # https://github.com/dotnet/diagnostics/issues/1950
 !IFDEF:OSX
 
-SOSCOMMAND:EEHeap -gc
 SOSCOMMAND:DumpStackObjects
 SOSCOMMAND:GCWhere <POUT>\w+\s+(<HEXVAL>)\s+([Gg][Cc]where!\$0_)*GCWhere\s+<POUT>
 # we care that the Gen is still 2 or 0 on Windows 3.x 

diff --git a/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterTriggerTests.cs b/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventCounterTriggerTests.cs
@@ -9,10 +9,12 @@
 using System;
 using System.ComponentModel.DataAnnotations;
 using System.Globalization;
+using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
+using Xunit.Extensions;
 
 namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
 {
@@ -313,9 +315,13 @@ public void EventCounterTriggerDropTest()
         /// Tests that the trigger condition can be detected on a live application
         /// using the EventPipeTriggerPipeline.
         /// </summary>
-        [Fact]
+        [SkippableFact]
         public async Task EventCounterTriggerWithEventPipePipelineTest()
         {
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2568");
+            }
             EventCounterTriggerSettings settings = new()
             {
                 ProviderName = EventCounterConstants.RuntimeProviderName,

diff --git a/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs b/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs
@@ -34,9 +34,14 @@ public EventLogsPipelineUnitTests(ITestOutputHelper output)
         /// <summary>
         /// Test that all log events are collected if no filters are specified.
         /// </summary>
-        [Fact]
+        [SkippableFact]
         public async Task TestLogsAllCategoriesAllLevels()
         {
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2541");
+            }
+
             using Stream outputStream = await GetLogsAsync(settings =>
             {
                 settings.UseAppFilters = false;
@@ -181,9 +186,13 @@ public async Task TestLogsUseAppFiltersAndFilterSpecs()
         /// <summary>
         /// Test that log events are collected for wildcard categories.
         /// </summary>
-        [Fact]
+        [SkippableFact]
         public async Task TestLogsWildcardCategory()
         {
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2568");
+            }
             using Stream outputStream = await GetLogsAsync(settings =>
             {
                 settings.UseAppFilters = false;