Skip to content

Commit

Permalink
[tests] Update EventLogsPipelineUnitTests referenced issue (#4905)
Browse files Browse the repository at this point in the history
Some EventLogsPipelineUnitTests originally disabled for Windows began
failing on other platforms. They were additionally disabled for all
platforms, referencing issue
#4718.

#4718 was closed, opting to
use #2541 as the main
tracking issue.

Update the issue reference to reflect this.
  • Loading branch information
mdh1418 authored Sep 5, 2024
1 parent 8bc9e2a commit 3eb66d2
Showing 1 changed file with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,9 @@ public async Task TestLogsAllCategoriesAllLevels(TestConfiguration config)
/// <summary>
/// Test that log events at or above the default level are collected.
/// </summary>
[SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/4718"), MemberData(nameof(Configurations))]
[SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/2541"), MemberData(nameof(Configurations))]
public async Task TestLogsAllCategoriesDefaultLevel(TestConfiguration config)
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2541");
}

using Stream outputStream = await GetLogsAsync(config, settings => {
settings.UseAppFilters = false;
settings.LogLevel = LogLevel.Warning;
Expand Down Expand Up @@ -169,14 +164,9 @@ public async Task TestLogsUseAppFilters(TestConfiguration config)
/// Test that log events are collected for the categories and levels specified by the application
/// and for the categories and levels specified in the filter specs.
/// </summary>
[SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/4718"), MemberData(nameof(Configurations))]
[SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/2541"), MemberData(nameof(Configurations))]
public async Task TestLogsUseAppFiltersAndFilterSpecs(TestConfiguration config)
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2541");
}

using Stream outputStream = await GetLogsAsync(config, settings => {
settings.FilterSpecs = new Dictionary<string, LogLevel?>()
{
Expand Down

0 comments on commit 3eb66d2

Please sign in to comment.