Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR feedback on the "verifiable ref returns" proposal #31

Merged
merged 3 commits into from
Jan 25, 2018
Merged

PR feedback on the "verifiable ref returns" proposal #31

merged 3 commits into from
Jan 25, 2018

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented Jan 24, 2018

No description provided.

@VSadov VSadov mentioned this pull request Jan 24, 2018
Merged
@VSadov
Copy link
Member Author

VSadov commented Jan 24, 2018 •
edited
Loading

@MichalStrehovsky - please take a look.

After thinking a bit about whether IsReturnable should be an attribute, I am getting convinced that it should be just a regular class like IsConst. Its only foreseeable target is IL local slots and that is not even expressible in AttributeTargets enum. - Making this type an attribute seems unnecessary and perhaps confusing.

@VSadov
Copy link
Member Author

VSadov commented Jan 25, 2018

Thanks!!

@VSadov VSadov merged commit ab72004 into dotnet:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VSadov @MichalStrehovsky