-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TFM for .NET nanoFramework #208
Conversation
7a8accd
to
dbc0f1d
Compare
Does this mean that the .NET SDK should support building projects targeting .NET Nano out of the box? If not, then how would you build those projects? Where would the reference assemblies come from? Basically what is in the spec looks good, but I think there's more to consider for how this experience would work beyond the TFM and NuGet. |
That is a good question. Right now, my understanding is that Nano Framework is not SDK-style and uses the old project system via some custom targets. @Ellerbach or @josesimoes should elaborate. I think ultimately it's desirable to use the .NET SDK to target Nano Framework as well, so that they can use the new project system, multi targeting, and build NuGet packages but I think we can probably scope this out to a later work item. |
This is correct. Kind of a "chicken and the egg" problem. We don't have a TFM -> can't use SDK style -> need to use SDK style -> don't have a TFM to support that.
Absolutely! This is the ultimate goal of this effort: to integrate seamlessly in the .NET tooling, VS and ecosystem. |
Yes, please read my comment above. Currently we are distributing all our assemblies as NuGet packages. Including custom mscorlib version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me except for the branding and few related elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a little one to correct!
Should there be a reviewer from nuget team? |
@terrajobst just noticed that the MD file name seems to have a typo... The name is nan-framework-tfm, maybe missing the 'o' in nano? |
That's why I tagged @nkolev92 😀 |
Of course. I'm a typo generator 😀 Will fix. |
cfdef1d
to
4c9dde8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! :)
991de7c
to
4c9dde8
Compare
@terrajobst that works for me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/cc @Ellerbach @josesimoes