Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFM for .NET nanoFramework #208

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

terrajobst
Copy link
Member

@dsplaisted
Copy link
Member

Does this mean that the .NET SDK should support building projects targeting .NET Nano out of the box? If not, then how would you build those projects? Where would the reference assemblies come from?

Basically what is in the spec looks good, but I think there's more to consider for how this experience would work beyond the TFM and NuGet.

@terrajobst
Copy link
Member Author

That is a good question. Right now, my understanding is that Nano Framework is not SDK-style and uses the old project system via some custom targets. @Ellerbach or @josesimoes should elaborate.

I think ultimately it's desirable to use the .NET SDK to target Nano Framework as well, so that they can use the new project system, multi targeting, and build NuGet packages but I think we can probably scope this out to a later work item.

@josesimoes
Copy link

That is a good question. Right now, my understanding is that Nano Framework is not SDK-style and uses the old project system via some custom targets. @Ellerbach or @josesimoes should elaborate.

This is correct. Kind of a "chicken and the egg" problem. We don't have a TFM -> can't use SDK style -> need to use SDK style -> don't have a TFM to support that.

I think ultimately it's desirable to use the .NET SDK to target Nano Framework as well, so that they can use the new project system, multi targeting, and build NuGet packages but I think we can probably scope this out to a later work item.

Absolutely! This is the ultimate goal of this effort: to integrate seamlessly in the .NET tooling, VS and ecosystem.

@josesimoes
Copy link

Does this mean that the .NET SDK should support building projects targeting .NET Nano out of the box? If not, then how would you build those projects? Where would the reference assemblies come from?

Yes, please read my comment above.

Currently we are distributing all our assemblies as NuGet packages. Including custom mscorlib version.

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me except for the branding and few related elements

INDEX.md Outdated Show resolved Hide resolved
accepted/2021/nano-framework-tfm/nan-framework-tfm.md Outdated Show resolved Hide resolved
accepted/2021/nano-framework-tfm/nan-framework-tfm.md Outdated Show resolved Hide resolved
accepted/2021/nano-framework-tfm/nan-framework-tfm.md Outdated Show resolved Hide resolved
@terrajobst terrajobst changed the title TFM for .NET Nano Framework TFM for .NET nanoFramework Apr 24, 2021
@terrajobst terrajobst marked this pull request as ready for review April 24, 2021 15:21
Copy link

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯👌

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little one to correct!

accepted/2021/nano-framework-tfm/nan-framework-tfm.md Outdated Show resolved Hide resolved
@danmoseley
Copy link
Member

Should there be a reviewer from nuget team?

@dsplaisted dsplaisted requested a review from zkat April 25, 2021 17:41
@josesimoes
Copy link

@terrajobst just noticed that the MD file name seems to have a typo... The name is nan-framework-tfm, maybe missing the 'o' in nano?

@terrajobst
Copy link
Member Author

terrajobst commented Apr 25, 2021

Should there be a reviewer from nuget team?

That's why I tagged @nkolev92 😀

@terrajobst
Copy link
Member Author

@terrajobst just noticed that the MD file name seems to have a typo... The name is nan-framework-tfm, maybe missing the 'o' in nano?

Of course. I'm a typo generator 😀 Will fix.

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@terrajobst
Copy link
Member Author

@zkat @nkolev92 How do you want to track the work? Sufficient if I file an issue in nuget/nuget?

@zkat
Copy link
Contributor

zkat commented Apr 26, 2021

@terrajobst that works for me :)

Copy link

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants