Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
RussKie authored Jul 13, 2021
1 parent 2ea2b0e commit 6840a71
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions accepted/2021/winforms/streamline-application-bootstrap.md
Original file line number Diff line number Diff line change
Expand Up @@ -427,10 +427,10 @@ E.g.:
Application.SetDefaultFont(new Font(new FontFamily("Calibri"), 11f, FontStyle.Italic | FontStyle.Bold, GraphicsUnit.Point));
```

It would rather be impractical to provide an MSBuild properties for each argument the `Font` constructor takes, and instead the proposal is to configure fonts via a single property `ApplicationFont`. This property will have a format equivalent to the output of `FontConverter.ConvertToInvariantString()` API e.g.:
It would rather be impractical to provide an MSBuild properties for each argument the `Font` constructor takes, and instead the proposal is to configure fonts via a single property `ApplicationFont`. This property will have a format equivalent to the output of [`FontConverter.ConvertToInvariantString()` API](https://github.com/dotnet/runtime/blob/00ee1c18715723e62484c9bc8a14f517455fc3b3/src/libraries/System.Drawing.Common/src/System/Drawing/FontConverter.cs#L29-L86) e.g.:

```
Name=fontName[, Size=size[, Units=units[, GDiCharSet=gdiCharSet[, GdiVerticalFont=boolean]]]]
<FontName>, <Size><Size units>[, Style=[style1 [, style2[, ...]]]]
```

#### Locale aware font configuration
Expand Down Expand Up @@ -513,4 +513,4 @@ However we need to be congnisant of the fact that Windows Forms apps often have

### Does this approach align/conflict with other UI SDKs, e.g. WPF or WinUI?

Other UI SDKs (e.g. WPF and UWP) are XAML-based, and their designers read the same XAML files as their runtime, and run essentially the same app just in a different context (shell/window integration, app model). WinUI doesn't currently have a designer.
Other UI SDKs (e.g. WPF and UWP) are XAML-based, and their designers read the same XAML files as their runtime, and run essentially the same app just in a different context (shell/window integration, app model). WinUI doesn't currently have a designer.

0 comments on commit 6840a71

Please sign in to comment.