Propose relaxed ordering for partial and ref modifiers #8134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
commented
May 17, 2024
|
|
||
| ```diff | ||
| property_declaration | ||
| - : attributes? property_modifier* type member_name property_body | ||
| + : attributes? property_modifier* 'partial'? type member_name property_body |
There was a problem hiding this comment.
reading diffs of diffs can be challenging even in simple cases like this, so consider just reading the old version then the new version to understand what's going on.
|
@jcouv suggested this aspect of the feature could probably wait till after merge to main. I will probably leave this PR open until it's time to do that work (which shouldn't be too long). |
|
We still want to do this but will be punting impl work on it out to .NET 10. |
Should this go into a separate proposal then? |
|
Yeah I'll push such a change to this PR when I get the chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/roslyn#73090
#946
Spec'ing this related small feature as the partial properties speclet said we would do.