Allow operators in constant pattern

[wise0704]

another one I missed

[JoeRobich]

Thanks @wise0704!

[kasperk81]

@wise0704 are these related to https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/functional/pattern-matching? see or is not highlighted:

if (day is DayOfWeek.Monday or DayOfWeek.Wednesday) { }

[JoeRobich]

@kasperk81 Where are you seeing or not being highlighted? I can see it is being given the correct textmate scope.

[kasperk81]

@JoeRobich i was using vscode and github. github has three months cycle, so their next release will capture the changes on dec 12 that were made here after sep 19 (their last release): github-linguist/linguist#6627. i'm not sure about vscode's cadence.

[JoeRobich]

@kasperk81 For GitHub highlighting, you may also want to check with https://github.com/tree-sitter/tree-sitter-c-sharp as I know they are moving more languages away from the textmate grammars. This test in particular makes me wonder if it is supported.

[lildude]

👋 from Linguist. I can confirm we do indeed use the tree-sitter grammar on GitHub.com as shown the this line in the vendor/README.md file for highlighting C# files.

We do however still ship this grammar with Linguist for other languages which might reference the source.cs scope in their grammar. With that in mind, whilst the C# highlighting won't be affected, other grammars might be affected by these errors which were picked up by our compiler yesterday:

- repository `vendor/grammars/csharp-tmLanguage` (from https://github.com/dotnet/csharp-tmLanguage) (4 errors)
  - Invalid regex in grammar: `source.cs` (in `grammars/csharp.tmLanguage`) contains a malformed regex (regex "`(?<!\.\s*)\b(await)\b`": lookbehind assertion is not fixed length (at offset 9))
  - Invalid regex in grammar: `source.cs` (in `grammars/csharp.tmLanguage`) contains a malformed regex (regex "`\G(?=(?~\*/)$)`": unrecognized character after (? or (?- (at offset 7))
  - Invalid regex in grammar: `source.cs` (in `grammars/csharp.tmLanguage`) contains a malformed regex (regex "`^(\s*+)(\*(?!/))?(?=(?~\*/)$)`": unrecognized character after (? or (?- (at offset 22))
  - Invalid regex in grammar: `source.cs` (in `grammars/csharp.tmLanguage`) contains a malformed regex (regex "`(?<!\.\s*)\b(await)\b`": lookbehind assertion is not fixed length (at offset 9))

These are likely to all be because the grammar compiler enforces PCRE rules because the old highlighting engine that uses this grammar uses PCRE for performance reasons. Feel free to ignore these and I'll keep tracking them as I do all the others in github-linguist/linguist#3924

[kasperk81]

@damieng would know better but it does seem to recognize or as binary_pattern in playground https://tree-sitter.github.io/tree-sitter/playground

assuming linguist update on dec 12 will take the latest tree-sitter-csharp i will just wait. thanks for the info! :)

[lildude]

assuming linguist update on dec 12 will take the latest tree-sitter-csharp i will just wait. thanks for the info! :)

Linguist updates don't influence the treesitter grammar updates. They happen at their own cadence performed by the team that owns the highlighting service.

[kasperk81]

thanks @lildude. i can then only hope that it won't take long before they update the service. (unless someone can poke them) ;)