Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Option added to ignore specific errors #7905

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

LTruijens
Copy link
Contributor

  • Option added to ignore specific errors

This option can be useful when verifying large sets of dlls which contain lots of the same errors (like InitOnly dotnet/roslyn#22485).

  • App returns error code when verification errors exist

Useful in automation scenarios

  • Print error code

Useful to know the error code if you want to ignore it.

  • Continue verification when printing method fails

Otherwise it will stop any further output of the app

- App returns error code when verification errors exist
- Print error code
- Continue verification when printing method fails
@dnfclas
Copy link

dnfclas commented Dec 6, 2019

CLA assistant check
All CLA requirements met.

@jkotas
Copy link
Member

jkotas commented Dec 7, 2019

@LTruijens The change looks good. Thank you! Just curious - what are you using ILVerify for?

@jkotas jkotas merged commit 093c4e3 into dotnet:master Dec 7, 2019
@LTruijens
Copy link
Contributor Author

@LTruijens The change looks good. Thank you! Just curious - what are you using ILVerify for?

Great. Thank you for accepting.

We build an enterprise level line of business application which consists of several separate modules. Each module is developed by a different team and joined together in one single product. We need to make sure that all references are met and all calls to methods and types used are there. We are not worried about wrong IL code (we trust the C# compiler), but more about having a consistent set of dlls to package and deliver. We run ILVerify over a large set of dlls in an automated process as part of our packaging.

We used peverify, but are now moving to .Net standard and .Net core for which peverify does not work. We haven't found any other tools meeting our requirements and although ILVerify probably is overkill (as was peverify), it does seem to fit our needs.

@LTruijens LTruijens deleted the ilverify-ignore-error branch December 9, 2019 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants