Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/3.1] update Ubuntu and Alpine RID #42928

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented May 28, 2020

This is port of dotnet/runtime#37031 to add new RID for Ubuntu and Alpine releases.

fixes dotnet/runtime#37000

I'm not sure what the approval process is for this @danmosemsft.
Discussion in #42871 sugests "tell-mode" but I'm not sure if that is still correct.

@wfurt wfurt added the Servicing-consider Issue for next servicing release review label May 28, 2020
@wfurt wfurt requested review from ericstj and bartonjs May 28, 2020 20:01
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 2, 2020
@danmoseley
Copy link
Member

@wfurt my bad, missed your question. you do not need approval for RID changes and other changes just related to keeping up with distros. just set servicing-approved and @Anipik will merge it. (It's best for him to merge as sometimes branches are closed)

Should there be a change for 2.1 as well?

@danmoseley danmoseley added this to the 3.1.6 milestone Jun 2, 2020
@wfurt
Copy link
Member Author

wfurt commented Jun 2, 2020

I don't know @danmosemsft. I can look at 2.x history and craft PR as well if needed.

@danmoseley
Copy link
Member

@wfurt I verified at tactics -- yes, please port to 2.1 and again consider approved, for anirudh to merge.

@wfurt wfurt merged commit 34acb32 into dotnet:release/3.1 Jun 2, 2020
@danmoseley
Copy link
Member

@Anipik is branch open? that's why i figured it's best that you do all the merges

@wfurt
Copy link
Member Author

wfurt commented Jun 2, 2020

ops. sorry. I can roll it back.

@danmoseley
Copy link
Member

I'll let @Anipik say but almost surely it's fine. I just don't keep track of when branch is open or not.

@Anipik
Copy link

Anipik commented Jun 4, 2020

The branch is supposed to open next tuesday. I can help here and make sure we dont produce a new build.

@wfurt
Copy link
Member Author

wfurt commented Jun 4, 2020

thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants