This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove cancellation token from new System.Data CloseAsync() #39070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 1, 2019
|
@roji this would fix #39069. |
divega
approved these changes
Jul 1, 2019
Affects DbDataReader and DbConnection, since these APIs are very likely to be used for cleanup only, in which case a cancellation token is an anti-pattern (similar to why DisposeAsync doesn't accept one). See discussion here: dotnet/standard#1283 (review) Fixes #39069
roji
force-pushed
the
SystemDataRemoveCloseCancellation
branch
from
edc66c3 to
2f889e9
Compare
|
Thanks, my head got turned around with all the issues around this - amended the commit. |
|
cc: @terrajobst, @danmosemsft This is a post-Preview7 breaking API change. Presumably it needs more scrutiny? |
stephentoub
approved these changes
Jul 1, 2019
stephentoub
added
the
* NO MERGE *
|
Approved for preview7 |
wtgodbe
removed
the
* NO MERGE *
wtgodbe
pushed a commit
to wtgodbe/corefx
that referenced
this pull request
Jul 2, 2019
…9070) Affects DbDataReader and DbConnection, since these APIs are very likely to be used for cleanup only, in which case a cancellation token is an anti-pattern (similar to why DisposeAsync doesn't accept one). See discussion here: dotnet/standard#1283 (review) Fixes #39069
roji
added a commit
to roji/standard
that referenced
this pull request
Jul 2, 2019
Leftover from dotnet#1283, mirrors dotnet/corefx#39070
wtgodbe
pushed a commit
to dotnet/standard
that referenced
this pull request
Jul 2, 2019
Leftover from #1283, mirrors dotnet/corefx#39070
wtgodbe
added a commit
that referenced
this pull request
Jul 2, 2019
…39122) Affects DbDataReader and DbConnection, since these APIs are very likely to be used for cleanup only, in which case a cancellation token is an anti-pattern (similar to why DisposeAsync doesn't accept one). See discussion here: dotnet/standard#1283 (review) Fixes #39069
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…orefx#39070) Affects DbDataReader and DbConnection, since these APIs are very likely to be used for cleanup only, in which case a cancellation token is an anti-pattern (similar to why DisposeAsync doesn't accept one). See discussion here: dotnet/standard#1283 (review) Fixes dotnet/corefx#39069 Commit migrated from dotnet/corefx@539ed31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects DbDataReader and DbConnection, since these APIs are very likely to be used for cleanup only, in which case a cancellation token is an anti-pattern (similar to why DisposeAsync doesn't accept one).
/cc @stephentoub @terrajobst @divega @ajcvickers
See discussion here: dotnet/standard#1283 (review) (I propose to keep conversation in that issue)
Fixes #39060