This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Unix SslStream: Implement RFC2812 IP Address matching for HTTP over TLS. #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the hostname looks like an IP Address then do exact matches against GEN_IPADDR Subject Alternative Name entries. Unlike the GEN_DNS matching of text hostnames, the IP Address form always falls back to the CN text comparison if no other match has been found.
bartonjs
force-pushed
the
unix_sslstream_ipaddress
branch
from
b00dbfb to
b8ad721
Compare
| continue; | ||
| } | ||
|
|
||
| if (!memcmp(addressBytes, ipAddr->data, (size_t)addressBytesLen)) |
There was a problem hiding this comment.
I assume we don't have to worry about byte order?
There was a problem hiding this comment.
RFC 3280 defines that iPAddress values within the subjectAltName extension are in network-byte-order. And while the MSDN documentation is a bit sparse for IPAddress.GetAddressBytes(), it seems to be returning things in network-byte-order.
|
LGTM |
stephentoub
added a commit
that referenced
this pull request
Oct 14, 2015
Unix SslStream: Implement RFC2812 IP Address matching for HTTP over TLS.
|
LGTM. Sorry about the delay |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…address Unix SslStream: Implement RFC2812 IP Address matching for HTTP over TLS. Commit migrated from dotnet/corefx@127809a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the hostname looks like an IP Address then do exact matches against GEN_IPADDR Subject Alternative Name entries. Unlike the GEN_DNS matching of text hostnames, the IP Address form always falls back to the CN text comparison if no other match has been found.
Fixes #3445.
cc: @vijaykota @stephentoub @rajansingh10 @shrutigarg @CIPop @davidsh