This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
JsonSerializerOptions API update and ignore property features #36776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
reviewed
Apr 11, 2019
src/System.Text.Json/src/System/Text/Json/Serialization/JsonIgnoreAttribute.cs
Show resolved
Hide resolved
|
|
||
| internal abstract object GetValueAsObject(object obj, JsonSerializerOptions options); | ||
| bool hasIgnoreAttribute = (GetAttribute<JsonIgnoreAttribute>() != null); |
There was a problem hiding this comment.
nit: remove unnecessary brackets.
There was a problem hiding this comment.
I have a slight preference and think the brackets make it more obvious that this is a bool... Willing to change it however if I'm the only one :)
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfo.cs
Outdated
Show resolved
Hide resolved
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfo.cs
Outdated
Show resolved
Hide resolved
| options = new JsonSerializerOptions(); | ||
| options.WriteIndented = true; | ||
| json = JsonSerializer.ToString(obj, options); | ||
| Assert.Contains("\r", json); |
There was a problem hiding this comment.
I am surprised this is passing on unix.
There was a problem hiding this comment.
Yes... I assume the writer is using Environment.NewLine?
steveharter
force-pushed
the
JsonOptions
branch
from
21ac47b
to
6a24905
Compare
ahsonkhan
reviewed
Apr 15, 2019
| @@ -162,7 +162,7 @@ public JsonCommentHandling ReadCommentHandling | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Defines whether the <see cref="Utf8JsonWriter"/> should pretty print the JSON which includes: | |||
| /// Defines whether JSON should pretty print which includes: | |||
There was a problem hiding this comment.
JSON should be pretty printed
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the approved API changes. Includes some new functionality including an [Ignore] that can be applied to properties and ability to ignore just read-only properties on serialization via options.IgnoreReadOnlyProperties.
Fixes https://github.com/dotnet/corefx/issues/34372