This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
OpenSSL: Drop pal_asn1_print in favor of the managed code #30868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Windows x64 Debug Build |
bartonjs
reviewed
Jul 6, 2018
| value = reader.ReadUtf8String(); | ||
| break; | ||
|
|
||
| // Ignore anything we don't know how to read. |
There was a problem hiding this comment.
Should T61 be in this switch now?
There was a problem hiding this comment.
Good catch, it should!
bartonjs
approved these changes
Jul 6, 2018
|
@dotnet-bot Test Linux arm Release Build please (the build timed out) |
|
@dotnet-bot test Linux arm Release Build please |
stephentoub
approved these changes
Jul 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: The
d2i_ASN1_type_bytesAPI has been removed from OpenSSL 1.1 and BoringSSL. In another PR the X500NameEncoder.OpenSslDecode.cs implementation was recently dropped in favor of the managed implementation using DerSequenceReader. This change drops the OpenSSL ASN.1 string parsing in favor of the code that is already used on macOS and that is consistent with the rest of the CoreFX code in treatment of T61 strings.Extracted from PR #30807.