Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/2.1] Skip certificates we can't read when populating machine store. (#29973) #30155

Merged
merged 1 commit into from
Jun 26, 2018
Merged

[release/2.1] Skip certificates we can't read when populating machine store. (#29973) #30155

merged 1 commit into from
Jun 26, 2018

Conversation

stephentoub
Copy link
Member

@tmds @stephentoub
Skip certificates we can't read when populating machine store. (dotne…
422c9ca 
…t#29973)

* Skip certificates we can't read when populating machine store.

This is a regression in 2.1.0 (dotnet#29351).

Fixes https://github.com/dotnet/corefx/issues/29942.

* Add test

* Assert chmod returns 0

* Skip test on OSX

* Add valid content to the unreadable cert file
@stephentoub stephentoub added the Servicing-consider Issue for next servicing release review label Jun 5, 2018
@stephentoub stephentoub added this to the 2.1.x milestone Jun 5, 2018
@stephentoub
Copy link
Member Author

@ericstj, do you know what's going on here?
https://ci3.dot.net/job/dotnet_corefx/job/release_2.1/job/windows-TGroup_all+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/202/

D:\j\workspace\windows-TGrou---27e62afc\Tools\Packaging.targets(435,5): error : Cannot harvest package 'System.Net.WebSockets.WebSocketProtocol' version '4.5.0' because D:\j\workspace\windows-TGrou---27e62afc\packages/System.Net.WebSockets.WebSocketProtocol\4.5.0 does not exist.  Harvesting is needed to redistribute assets and ensure compatiblity with the previous release.  You can disable this by setting HarvestStablePackage=false. [D:\j\workspace\windows-TGrou---27e62afc\src\System.Net.WebSockets.WebSocketProtocol\pkg\System.Net.WebSockets.WebSocketProtocol.pkgproj]

@stephentoub stephentoub added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 6, 2018
@pjanotti
Copy link
Contributor

@ericstj I guess that this is being held by the packaging issue mentioned above by @stephentoub, do you know what is going on with it? We are getting more reports of users hitting this on 2.1:

https://github.com/dotnet/corefx/issues/30641
https://github.com/dotnet/corefx/issues/30635

@ericstj
Copy link
Member

ericstj commented Jun 25, 2018

/cc @weshaggard @wtgodbe

This means that the PackageIndex knows that WebSocketProtocol has a stable version of 4.5.0 but that version isn't being downloaded by external\harvestPackages.

The fix is to add it to https://github.com/dotnet/corefx/blob/release/2.1/external/harvestPackages/harvestPackages.props.

@stephentoub
Copy link
Member Author

@dotnet-bot test Packaging All Configurations x64 Debug Build please

@stephentoub stephentoub merged commit 5ae4912 into dotnet:release/2.1 Jun 26, 2018
@stephentoub stephentoub deleted the port29973 branch June 26, 2018 23:46
@NicolasDorier NicolasDorier mentioned this pull request Jul 24, 2018
Closed
@danmoseley danmoseley removed the Servicing-consider Issue for next servicing release review label Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs approved these changes

@pjanotti pjanotti pjanotti approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Security * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
2.1.x
Development

Successfully merging this pull request may close these issues.
7 participants
@stephentoub @pjanotti @ericstj @bartonjs @karelz @danmoseley @tmds