This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix globalization tests to work with setting customization #24052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used new CultureInfo in many places to check the NumberFormatInfo properties values . these tests can fail if the user customized the user settings on the running machine. The fix here is to use GetCultureInfo which always ignore the change in the settings and return the original values we need to test against.
|
This change should fix the failures in the globalization tests reported in the issue #23992 |
|
Interesting, so |
mellinoe
approved these changes
Sep 14, 2017
Yes, CultureInfo.GetCultureInfo creates a culture with disabling the user overrides. it is similar to new CultureInfo(name, false). CultureInfo.GetCultureInfo is useful for caching too so we don't create a new object every time but the created object will be read only. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…refx#24052) We used new CultureInfo in many places to check the NumberFormatInfo properties values . these tests can fail if the user customized the user settings on the running machine. The fix here is to use GetCultureInfo which always ignore the change in the settings and return the original values we need to test against. Commit migrated from dotnet/corefx@708c20a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used new CultureInfo in many places to check the NumberFormatInfo properties values. these tests can fail if the user customized the user settings on the running machine. The fix here is to use GetCultureInfo which always ignore the change in the settings and return the original values we need to test against.