This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Allow Deprecated and non-deprecated HTTP events simultaneously. #19659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses https://github.com/dotnet/corefx/issues/18762 Basically we always check if a client needs deprecated events (previously we checked only if new events were not enabled). This allows clients to support both new and old simultaneously.
lmolkova
reviewed
May 11, 2017
| @@ -129,7 +129,7 @@ internal static bool IsEnabled() | |||
| }); | |||
| } | |||
| //if Activity events are disabled, try to write System.Net.Http.Response event (deprecated) | |||
There was a problem hiding this comment.
nit: please update comment here as well
|
Could you please also update guide? It mentions that events are mutually exclusive. |
lmolkova
approved these changes
May 11, 2017
|
@dotnet-bot test Innerloop Tizen armel Debug Cross Build |
|
@dotnet-bot test Innerloop Ubuntu14.04 arm Release Cross Build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18762
Basically we always check if a client needs deprecated events (previously we checked only if new events were not enabled).
This allows clients to support both new and old events simultaneously.
@davidsh @lmolkova @avanderhoorn