-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Lift Microsoft.NETCore.Targets to reduce v1 conflicts #18341
Conversation
This reverts commit e1289e6.
Include the update to v1 lineup package, which now has no runtime package mappings. This will reduce the number of packages downloaded when mixing v1 and later packages as well as reduce our dependence on conflict resolution for dropping those v1 runtime packages.
@dotnet-bot test this please |
@@ -0,0 +1,92 @@ | |||
{ | |||
"supports": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to keep these supports clauses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folks who use them would be broken if we removed them. I felt like removing them was an unnecessary breaking change.
packages as well as reduce our dependence on conflict resolution for dropping | ||
those v1 runtime packages --> | ||
<Dependency Condition="'$(IsLineupPackage)' == 'true'" Include="Microsoft.NETCore.Targets"> | ||
<Version>2.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not be a ProjectReference as opposed to hardcoding the version? Also is there much reason to reference this in the private transport packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason to not be a ProjectReference
It was what we were doing for platforms and it reduces a bit of build time. I thought about this when making the change and I didn't expect us to ever update this dependency. In fact, we'll likely delete the package authoring after 2.0, but keep the reference.
reason to reference this in the private transport packages
I'm just using that to flow the dependency, we could instead add the reference to the package in core-setup if we wanted.
Merging. OSX build seems to be hitting lab issues again. |
Include the update to v1 lineup package, which now has no runtime package
mappings.
This will reduce the number of packages downloaded when mixing v1 and
later packages as well as reduce our dependence on conflict resolution
for dropping those v1 runtime packages.
Fixes #18088
Requires dotnet/core-setup#2053
/cc @weshaggard @joperezr