Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Expose GC.GetAllocatedBytesForCurrentThread in netcoreapp1.1 #12489

Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 9, 2016

No description provided.

@jkotas
Copy link
Member Author

jkotas commented Oct 9, 2016

Fix #10157

cc @Maoni0

@stephentoub
Copy link
Member

@dotnet-bot Test Innerloop Ubuntu14.04 Debug Build and Test please (build timeout) FYI, @mmitche and @adityamandaleeka

@stephentoub
Copy link
Member

LGTM

@stephentoub stephentoub merged commit a8f2bf2 into dotnet:master Oct 9, 2016
@jkotas jkotas deleted the GetAllocatedBytesForCurrentThread branch October 9, 2016 15:00
@mmitche
Copy link
Member

mmitche commented Oct 9, 2016

@stephentoub Are you sure we should be merging these? They're timeouts while running tests.

/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/Tools/tests.targets(271,5): error : One or more tests failed while running tests from 'System.Reflection.Emit.Tests' please check log for details! [/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_debug_prtest/src/System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj]

@stephentoub
Copy link
Member

@mmitche, that's how the issue I've been mentioning on Ubuntu manifests, and why I've started to cc you and Aditya. It's not specific to any particular test suite; it just ends up spinning page failing at seemingly random places. This PR didn't change and doesn't impact that test suite.

@Maoni0
Copy link
Member

Maoni0 commented Oct 10, 2016

cool :) thanks Jan. @swgillespie, @KrzysztofCwalina, - you don't need to use reflection on this anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants