This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix XML comments in ManagedWebSocket #10792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't currently build this library in corefx with XML doc comments enabled, several errors weren't getting caught, causing problems for ASP.NET, which shares this file. This fixes the errors that would resul tfrom the ManagedWebSocket.cs file if XML comment building was enabled, as it is for ASP.NET.
|
Awesome, thanks! I'll pull the latest from this branch and try it in our build. |
|
@dotnet-bot test Innerloop OSX Debug Build and Test please |
Thanks. Please let me know if you'd like me to port this over or if you're already in the process of doing so. |
|
I have a script to port changes over and apply the small additional changes we need, so I should be able to just re-run that. |
analogrelay
added a commit
to aspnet/WebSockets
that referenced
this pull request
Aug 15, 2016
analogrelay
added a commit
to aspnet/WebSockets
that referenced
this pull request
Aug 15, 2016
analogrelay
added a commit
to aspnet/WebSockets
that referenced
this pull request
Aug 19, 2016
* port dotnet/corefx#10792 * add EchoApp sample
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't currently build this library in corefx with XML doc comments enabled, several errors weren't getting caught, causing problems for ASP.NET, which shares this file. This fixes the errors that would resul tfrom the ManagedWebSocket.cs file if XML comment building was enabled, as it is for ASP.NET.
cc: @anurse
aspnet/WebSockets#107