Add TryAdd and Clear regression tests

dotnet · Sep 22, 2018 · e373d99 · e373d99
1 parent 5f7e07f
commit e373d99
Showing 1 changed file with 25 additions and 0 deletions.
diff --git a/src/System.Collections/tests/Generic/Dictionary/Dictionary.Tests.cs b/src/System.Collections/tests/Generic/Dictionary/Dictionary.Tests.cs
@@ -250,6 +250,31 @@ public void Remove_NonExistentEntries_DoesNotPreventEnumeration()
             }
         }
 
+        [Fact]
+        [Trait("MyTrait", "MyTraitValue")]
+        public void Clear_OnEmptyCollection_DoesNotInvalidateEnumerator()
+        {
+            Dictionary<string, string> dictionary = new Dictionary<string, string>();
+            var valuesEnum = dictionary.GetEnumerator();
+
+            dictionary.Clear();
+            Assert.Empty(dictionary);
+            valuesEnum.MoveNext();
+        }
+
+        [Fact]
+        [Trait("MyTrait", "MyTraitValue")]
+        public void Unsuccessful_TryAdd_DoesNotInvalidateEnumerator()
+        {
+            Dictionary<string, string> dictionary = new Dictionary<string, string>();
+            dictionary.Add("a", "b");
+
+            var valuesEnum = dictionary.GetEnumerator();
+            Assert.False(dictionary.TryAdd("a", "c")); 
+
+            valuesEnum.MoveNext();
+        }
+
         [Theory]
         [MemberData(nameof(CopyConstructorInt32Data))]
         public void CopyConstructorInt32(int size, Func<int, int> keyValueSelector, Func<IDictionary<int, int>, IDictionary<int, int>> dictionarySelector)