This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Support long paths in CoreCLR runtime on Windows #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoreCLR runtime is updated to support long file paths on Windows. Pending updates to mscorlib.dll, the following scenarios are supported: * Run managed apps from a long path. * Load CoreCLR runtime and framework from a long path. * Load user assemblies from a long path. * Run CrossGen from a long path, with its input/output from a long path. * Generate debug log file at a long path. The following scenarios are not yet supported, and will be fixed in future commits: * Mscorlib.dll and framework assemblies are not yet long path compatible. Note that until mscorlib.dll is fixed, most of the runtime changes can't actually be used. * Support on non-Windows platforms. * Support for debugging and error reporting. * Tools such as ilasm or ildasm.
|
LGTM |
|
lgtm |
|
|
||
| // Copy the directory path | ||
| ::wcsncpy_s(m_hostDirectoryPath, m_hostPath, lastBackslashIndex + 1); | ||
| m_hostDirectoryPath.Set(m_hostPath, m_hostPath.Begin(), lastBackslash + 1); |
There was a problem hiding this comment.
you can probably use the functionality of CopySystemDirectory like in :
Line 737 in 41fcf5d
There was a problem hiding this comment.
Thanks. I didn't realize CopySystemDirectory really means "get path from file name". It seems to be mis-named.
For this particular case, I still need to find the location of the last backslash, since I need it to create m_hostExeName below. Given that, there seems to be no more advantage to use CopySystemDirectory.
|
Except for the above comment, LGTM |
JohnChen0
pushed a commit
that referenced
this pull request
Mar 1, 2016
Support long paths in CoreCLR runtime on Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoreCLR runtime is updated to support long file paths on Windows.
Pending updates to mscorlib.dll, the following scenarios are supported:
The following scenarios are not yet supported, and will be fixed in
future commits:
Note that until mscorlib.dll is fixed, most of the runtime changes can't
actually be used.