This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Port of dotnet/runtime#1059 to 3.1 branch #27986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the fix for #27924. This is a GC hole bug that was found externally, #27590. The cause is that the JIT was using the target type of the subtract when it needed to make a copy of the source, but it needs to use the source type. ## Customer Impact Corruption of state that is non-deterministic and hard to track down. ## Regression? Not a recent regression, but exposed by Unsafe.ByteOffset. ## Testing The fix has been verified in the runtime repo. ## Risk Low: The fix is straightfoward and only impacts 3 lines of code.
|
Is this for 3.1.3? CC @jeffschwMSFT |
|
It has to be 3.1.3. Miss the 3.1.2 window already. |
|
Please add code reviewer. |
Added above |
jeffschwMSFT
added
the
Servicing-consider
jkotas
approved these changes
Jan 17, 2020
|
Approved for .NET Runtime |
jeffschwMSFT
added
Servicing-approved
|
Approved for 3.1.3 (March) - need to wait for the branch to open before merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #27924. This is a GC hole bug that was found externally, #27590.
The cause is that the JIT was using the target type of the subtract when it needed
to make a copy of the source, but it needs to use the source type.
Customer Impact
Corruption of state that is non-deterministic and hard to track down.
Regression?
Not a recent regression, but exposed by Unsafe.ByteOffset.
Testing
The fix has been verified in the runtime repo.
Risk
Low: The fix is straightfoward and only impacts 3 lines of code.
Code Reviewer
@jaschook and @jkotas