This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Avoid instantiating abstract class #27589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshung
changed the title
nattress
approved these changes
Nov 4, 2019
cshung
force-pushed
the
dev/andrewau/avoid-instantiate-abstract-class
branch
from
efd602c to
d767f30
Compare
davidwrighton
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for
crossgen2to encounter code trying to instantiate an abstract class, and we should refuse to generate code in those cases so that the JIT will throwInvalidOperationExceptionat runtime.This is not possible in C#, but it is possible to in
IL, for example, the code is instantiating the abstract classGen<T>here and the assembler produced the IL for it.@dotnet/crossgen-contrib