This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[Release/3.1] Fixes for profiler stack sampling #27300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meThreadSuspended() when requested by profiler (dotnet#27041) Fixes https://github.com/dotnet/coreclr/issues/26576
davmason
changed the title
|
approved for 3.1 |
k15tfu
approved these changes
Oct 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profilers often want to do stack sampling to do analysis of where an application is spending time. We have had the
DoStackSnapshotAPI for a while, but since Linux/macos do not have aSuspendThreadAPI like windows it was not possible to do sampling on non-windows platforms.In 3.0 we released
ICorProfilerInfo10::SuspendRuntimeto address this limitation. @k15tfu found two issues that are blocking his Linux profiler from doing stack sampling:SuspendRuntime(Use a new COR_PRF_SUSPEND_FOR_PROFILER in ICorProfilerCallback::Runti… #27041)This is a port of the fix for those two issues to 3.1.