This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[master] Move TypeSystemLog::OnKeywordsChanged #26270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Common to enable this same behavior in ETW and EventPipe. This unblocks parity for GCHeapDumps between ETW and EventPipe
noahfalk
approved these changes
Aug 20, 2019
sywhang
approved these changes
Aug 20, 2019
josalem
pushed a commit
to josalem/coreclr
that referenced
this pull request
Oct 14, 2019
…Common to enable this same behavior in ETW and EventPipe. This unblocks parity for GCHeapDumps between ETW and EventPipe (dotnet#26270)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…Common to enable this same behavior in ETW and EventPipe. This unblocks parity for GCHeapDumps between ETW and EventPipe (dotnet/coreclr#26270) Commit migrated from dotnet/coreclr@16e83a7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TypeSystemLog::OnKeywordsChanged from EtwCallback to EtwCallbackCommon to enable this same behavior in ETW and EventPipe. This unblocks parity for GCHeapDumps between ETW and EventPipe. This callback modifies some state in the type logging system used by ETW and EventPipe, but is currently only invoked by ETW. These state changes affect
I'm planning on doing some more manual testing of this change since some of the tracing scenarios may not be covered by CI.
This change is small and targeted in the event we port this to 3.x, but there are are potentially more things that only exist in
EtwCallbackthat may need to be moved toEtwCallbackCommon.CC- @tommcdon