This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[WIP] Support Write-Thru of EH variables in LSRA #26087
Closed
Closed
Commits on Nov 15, 2019
-
Support Write-Thru of EH variables in LSRA
Mark EH variables (those that are live in or out of exception regions) only as lvLiveInOutOfHndlr, not necessarily lvDoNotEnregister During register allocation, mark these as write-thru, and mark all defs as write-thru, ensuring that the stack value is always valid. Mark those defs with GTF_SPILLED (this the "reload" flag and is not currently used for pure defs) to indicate that it should be kept in the register. Mark blocks that enter EH regions as having no predecessor, and set the location of all live-in vars to be on the stack. Change genFnPrologCalleeRegArgs to store EH vars also to the stack if they have a register assignment. Tune callee-save heuristics for EH vars. Remove/modify mitigations
Configuration menu - View commit details
-
Copy full SHA for 490174b - Browse repository at this point
Copy the full SHA 490174bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e399633 - Browse repository at this point
Copy the full SHA e399633View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5632339 - Browse repository at this point
Copy the full SHA 5632339View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06545e6 - Browse repository at this point
Copy the full SHA 06545e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7198c74 - Browse repository at this point
Copy the full SHA 7198c74View commit details -
Configuration menu - View commit details
-
Copy full SHA for c57f67b - Browse repository at this point
Copy the full SHA c57f67bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04d85e0 - Browse repository at this point
Copy the full SHA 04d85e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c23f479 - Browse repository at this point
Copy the full SHA c23f479View commit details -
Configuration menu - View commit details
-
Copy full SHA for f00cb24 - Browse repository at this point
Copy the full SHA f00cb24View commit details -
- Change
gtIsLikelyRegVar
to return false for defs of EHvars, since…… they always go to memory. - Never split a block if the only resolution moves are for EH vars. - Add a test case to enable diff tracking for #21973
Configuration menu - View commit details
-
Copy full SHA for c2ae4dd - Browse repository at this point
Copy the full SHA c2ae4ddView commit details
Commits on Nov 20, 2019
-
Modify weight for EH vars in LIR Take into account how many callee save regs there are
Configuration menu - View commit details
-
Copy full SHA for f96f1cf - Browse repository at this point
Copy the full SHA f96f1cfView commit details
Commits on Nov 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c91dd3f - Browse repository at this point
Copy the full SHA c91dd3fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.