This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix: Diagnostics Server IPC thread causes 20-40ms shutdown delays on Windows #25602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
approved these changes
Jul 9, 2019
|
/cc @sergiy-k |
josalem
approved these changes
Jul 9, 2019
sywhang
approved these changes
Jul 10, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…Windows (dotnet/coreclr#25602) Now, the diagnostics server attempts to do appropriate cleanup of its resources during shutdown. ```log 1. Closes the IPC channel 2. if Windows: - Cancel sync IO operations on the running server thread 3. Closes the running server thread handle ``` This change alleviates the issue because it manually cancel the blocking `ConnectNamedPipe` sync call in order to allow the server thread exit gracefully (instead of waiting for the OS to tear it down). Fixes: https://github.com/dotnet/coreclr/issues/25463 Commit migrated from dotnet/coreclr@dedef28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the diagnostics server attempts to do appropriate cleanup of its resources during shutdown.
This change alleviates the issue because it manually cancel the blocking
ConnectNamedPipesync call in order to allow the server thread exit gracefully (instead of waiting for the OS to tear it down).Fixes: https://github.com/dotnet/coreclr/issues/25463