This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix project metadata in test #24119
Merged
Fix project metadata in test #24119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKeldorph
approved these changes
Apr 19, 2019
|
Thanks! |
| <AssemblyName>$(MSBuildProjectName)</AssemblyName> | ||
| <SchemaVersion>2.0</SchemaVersion> | ||
| <ProjectGuid>{95DFC527-4DC1-495E-97D7-E94EE1F7140D}</ProjectGuid> | ||
| <OutputType>Exe</OutputType> | ||
| <ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | ||
| <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir> | ||
| <CLRTestPriority>1</CLRTestPriority> | ||
|
|
||
| <!-- Test relies on rva_statics support see #2451 --> | ||
| <DisableProjectBuild>true</DisableProjectBuild> |
There was a problem hiding this comment.
This disables the project from building, and I believe disables the test from running.
Is this desired/applicable considering the test was just added?
There was a problem hiding this comment.
Also, it looks like some bug fixes have gone in related to https://github.com/dotnet/coreclr/issues/2451; is the issue still applicable to the other disabled tests?
There was a problem hiding this comment.
You are right. The test passes when i run it locally (unlike the neighboring ones which fail for me). I'll remove this.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix project metadata in test Commit migrated from dotnet/coreclr@76478fc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the metadata from the ilproj file of a neighboring test (rvastatics1.ilproj).
Fixes #24106